Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color-picker): fix shaking issue when selecting color with v-model #3180

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix(color-picker): fix shaking issue when selecting color with v-model #3180

merged 2 commits into from
Jul 26, 2024

Conversation

oljc
Copy link
Member

@oljc oljc commented Jun 11, 2024

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

选择颜色时出现的抖动问题

色值转换 hsv 时会出现小的误差导致抖动。开启 v-model外部颜色变化重新 setHsv 出现抖动。

Solution

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
color-picker 修复在 v-model 下选择颜色时出现的抖动问题 fix shaking issue when selecting color with v-model Closed #3174

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Jun 11, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@flsion flsion added the 🐛 Bug Something isn't working label Jul 26, 2024
@flsion flsion added this to the 2.56.0 milestone Jul 26, 2024
@flsion flsion merged commit 57a9834 into arco-design:main Jul 26, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐛 Bug Something isn't working
Projects
None yet
Milestone
2.56.0
2 participants
@oljc @flsion